Remove include/boost/gil/version.hpp file as unused #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - GIL is part of Boost collection, so Boost version is sufficient - GIL version makes little sense unless GIL becomes independent - Two distinct version numbers, Boost's and GIL's, are confusing. - Role of GIL's version number is not documented thus not entirely clear The removal was discussed and agreed upon in this thread https://lists.boost.org/boost-gil/2019/11/0346.php
stefanseefeld
approved these changes
Nov 6, 2019
|
Yes, I think I checked all places, and final grep checks return nothing |
mloskot
added a commit
that referenced
this pull request
Nov 23, 2019
mloskot
added a commit
that referenced
this pull request
Nov 23, 2019
* develop: Update Boost 1.72.0 release notes with PR #403 Mention C++11 in meta/libraries.json Add release notes in Markdown format (#404) Typo in README Remove include/boost/gil/version.hpp file as unused (#403) Add Markdown linting with Node package markdownlint doc/README.md: clarify steps building docs CONTRIBUTING.md: Remove logo as unnecessary README.md: Fix FreeNode link and hash escape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing
version.hppadded to GIL in dfc86f6 (Boost 1.68)Motivation:
References
The removal was discussed and agreed upon in this thread
https://lists.boost.org/boost-gil/2019/11/0346.php
Tasklist
/cc @stefanseefeld, @lpranam