-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image constructor from compatible view #520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Although this looks good to me too, I'm having issue about the terminology vs the code here. The subject of this PR says "from compatible view" brief look at the code immediately raised me a question:
In GIL, definition of view/pixel compatibility is based on color space compatibilty and the latter says:
which obviously is not equivalent of what this PR proposes. In GIL, we may want to distinguish view/pixel compatibility from view/pixel convertibility. Would you agree that the "from compatible view" should read "from convertible view"? |
Right, I forgot about How about Is Note that I am confused. Maybe we need some examples to clarify "convertible" vs "compatible"? My guess is gray8 -> gray16 : convertible? |
@sdebionne Sorry for delay.
Well, you know it best if this would be suitable for your intention in this PR.
Yes, to me it is different. The
Me too :-)
Yes we do! I guess, we could also start developing some more systematic system of type traits in GIL:
where What do you think?
That is how I understand it.
That is how I understand it, thanks to semantic kth-dereferencing of channels. |
Thanks for the clarification! I'll go for compatibility with this PR and use the more strict |
Cool. What do you think about the traits idea? Is this anything you'd see useful, a good direction, in future? |
Thanks @sdebionne |
Description
For convenience, this PR introduces a new image constructor to "materialize" (in the SQL sense) an image_view.
Tasklist