-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pmr image typedefs #529
Conversation
56f968d
to
979b7f1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #529 +/- ##
========================================
Coverage 80.84% 80.84%
========================================
Files 116 116
Lines 5121 5127 +6
========================================
+ Hits 4140 4145 +5
- Misses 981 982 +1 |
I would be happy to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By the way, see #676
I have updated this PR with latest |
The GCC 11 drops the warning:
and C++14 compilation mode is failing, obviously. Some |
Thanks for looking into the issue, |
* develop: test: Add more basic cases for image class (#423) test: Add virtual_2d_locator fixture; is_2d_traversable test case test: Check more properties of indexed_image_view from extension/toolbox test: Add basic is_1d_traversable cases for image_view chore: Update CMakeSettings.json sample [ci skip] chore: Update CMake to use latest cmake-conan/0.18.1 [ci skip] Add pmr image typedefs (#529) test: Add test cases for image with empty dimensions (#702) test: Case test_constructor_from_view was not called fix: Memory leak in image class for empty dimensions (#649) docs: Bump C++11 to C++14 as current required (#700) ci: Remove C++11 build jobs after C++14 switch (#698) build: Fix CMake source file extensions must be explicit refactor: Switch to trailing return types (#599) build: Bump Boost required by CMake from 1.72 to 1.80 build: Update CMAKE_CXX_STANDARD from 11 to 14
Description
when building with C++17 standard, adds pmr (polymorphic memroy resource) image typedefs (e.g.
gil::pmr::gray8_image_t = using image<gray8_pixel_t, false, std::pmr::polymorphic_allocator<unsigned char>
).Fixes #528.
Tasklist
<memory_resource>
and typedefs