Fix convolve_2d for images with float32_t channel model #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing this would help me submit a PR for harshitpant1@05ec89e |
|
will try to have a look as soon as possible then... |
|
Thanks. |
Codecov Report
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
+ Coverage 78.58% 78.72% +0.13%
===========================================
Files 117 118 +1
Lines 5002 5034 +32
===========================================
+ Hits 3931 3963 +32
Misses 1071 1071 |
3 tasks
mloskot
reviewed
Apr 2, 2021
mloskot
reviewed
Apr 2, 2021
mloskot
added
cat/bug
|
Thanks for looking into this, will remember your suggestions moving forward. |
3 tasks
meshtag
approved these changes
Oct 4, 2021
sdebionne
reviewed
Oct 5, 2021
|
@mloskot, do you think this can land in the |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convolve_2d currently does not work with images using float32_t channel model due to a trivial issue. This PR fixes that.
References
Fixes #575
Tasklist