Fix geometry bug in is_straight_line_drawing #412
+59
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"crosses" fits the requirement as it means that the interior parts of the geometry share some common points, not exterior parts such as end-points, and it means "not within".
|
Why is this assigned to me? |
Sorry I meant to leave a comment that I just wanted you to give it a sanity check. I've never used the numeric_cast before, but I presume it's as simple as this. |
|
I just don't really know who else to assign my own pull requests to, since I assume JZ Maddock wants to minimise his Boost workload these days. |
jeremy-murphy
force-pushed
the
388_is_straight_line_drawing
branch
from
689eb04 to
9176040
Compare
|
Whoops, accidentally pushed my CMake changes here and force-pushed to get rid of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the geometry bug uncovered and documented by @Hermann-SW by replacing the custom function with one from Boost.Geometry.
crossesmeets the requirement described in the old code for returning true for 'intersections' that don't include endpoints or self-intersection.I decided to remove the tolerance altogether on the assumption that it was indicative of a poor implementation.