Improve tanh_sinh. #714
Merged
Improve tanh_sinh. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significantly reduces the number of iterations in many cases.
|
Work in progress for #706 |
|
This is a major improvement to tanh_sinh. Is it realistic to get it into 1.78? |
That's a good question. I still have further improvements lurking on my HD (pruning the tails when they are trivially small), but I need to test them at various different precisions before signing off on those. I'm also not completely convinced we don't have a bug somewhere, something doesn't seem quite right, but I don't see what. That said, maybe we should merge what we have and continue this at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tanh_sinh: improve thrash detection.
Significantly reduces the number of iterations in many cases.