-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cygwin, FreeBSD and Long Doubles #729
Conversation
…ger define BOOST_MATH_NO_LONG_DOUBLE_MATH_FUNCTIONS
@mborland , @jzmaddock : I noticed that we haven't done a standalone for 1.78 yet; would it make sense to use this fix to tag a standalone? |
We could do, there are quite a few cygwin-related CI failures showing though. Some are trivial limits-set-to-low, others look a bit more worry-some at first glance. |
@mkoeppe Does SageMath use the standalone version of Boost.Math? If not I think we are safe to cut the standalone release without this. |
No |
Hi Matt (@mborland) this is not directly related to the exact build issue... Nonetheless, I've been wondering if the explicit use of the commit filter in the YAML script is still helpful or up-to-date or needed. My understanding is that GHA now comprehends the |
@jzmaddock Can you take a look at this? The error rates that Cygwin has for the special functions are in line with what MinGW produces so I don't see any serious problems there. I think for our purposes we can consider Cygwin as having appropriate long double support. |
Ping @jzmaddock |
Looks good to me, just out of interest, what's the issue with the tests that are disabled for cygwin? |
They all require big object support which still failed when the flag was passed due to a lack of support. |
Ah, yes, GCC's object size limit on windows is super annoying... merging. Thanks for this! |
Thanks a lot for working on this! |
Consolidates #727 and #728 to allow for other CI fixes before merge.