Change looping over array to be unsigned #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AtariDreams : Do you have an ASan log I could see? We should also probably add a unit test to ensure this doesn't happen again. |
|
@NAThompson No, I just noticed it was undefined behavior. |
mborland
requested changes
Oct 11, 2022
This way of writing the loops is better and does not invoke undefined behavior or implementation defined behavior since size_t is unsigned.
|
@mborland Ready! |
mborland
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way of writing the loops is better and does not invoke undefined behavior or implementation defined behavior since size_t is unsigned