Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang-15 warnings #831

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Fix Clang-15 warnings #831

merged 1 commit into from
Oct 9, 2022

Conversation

AZero13
Copy link
Contributor

@AZero13 AZero13 commented Oct 4, 2022

Redundant casts, noexcept for move constructors, and usage of default and delete make the code more performant and maintainable

@AZero13 AZero13 force-pushed the noexcept branch 3 times, most recently from ae6fb11 to d93eb4c Compare October 4, 2022 17:04
@ckormanyos
Copy link
Member

ckormanyos commented Oct 4, 2022

Hi @AtariDreams

Thanks for diving into this.
I did a quick appraisal of the results of the drone run in CI (which runs even without admin approval).

To my rather quick glance it seems like a lot of tests fail with these changes. I'm not sure exactly what went wrong, but I believe this should be investigated prior to running all of CI.

Cc: @jzmaddock and @NAThompson and @mborland

@jzmaddock
Copy link
Collaborator

There's a stray trailing "," in stats.hpp.

@AZero13
Copy link
Contributor Author

AZero13 commented Oct 5, 2022

Fixed!

@AZero13
Copy link
Contributor Author

AZero13 commented Oct 5, 2022

@ckormanyos

Redundant casts, noexcept for move constructors, and usage of default and delete make the code more performant and maintainable.
@ckormanyos
Copy link
Member

Hi @AtariDreams thanks for correcting these suggested corrections.

Could we wait a few hours or half a day or so before approving CI? John (@jzmaddock) has been working steadily and dilligently on some special functions correctins and these are cacling now.

I (or somebody) will approve this run after some of heavy action finishes up, which should be in a few hours.

Cc: @jzmaddock and @mborland and @NAThompson

@ckormanyos
Copy link
Member

To be more clear @AtariDreams to me it would seem nice to get #835 (cycling in CI now) merged (see work by @jzmaddock). Then merge that updated develop into your branch and then run all of CI.

Thoughts?

@AZero13
Copy link
Contributor Author

AZero13 commented Oct 9, 2022

That makes sense. Perfect!

@jzmaddock jzmaddock merged commit 38034fa into boostorg:develop Oct 9, 2022
@AZero13 AZero13 deleted the noexcept branch October 25, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants