-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Clang-15 warnings #831
Conversation
ae6fb11
to
d93eb4c
Compare
Hi @AtariDreams Thanks for diving into this. To my rather quick glance it seems like a lot of tests fail with these changes. I'm not sure exactly what went wrong, but I believe this should be investigated prior to running all of CI. Cc: @jzmaddock and @NAThompson and @mborland |
There's a stray trailing "," in stats.hpp. |
Fixed! |
Redundant casts, noexcept for move constructors, and usage of default and delete make the code more performant and maintainable.
Hi @AtariDreams thanks for correcting these suggested corrections. Could we wait a few hours or half a day or so before approving CI? John (@jzmaddock) has been working steadily and dilligently on some special functions correctins and these are cacling now. I (or somebody) will approve this run after some of heavy action finishes up, which should be in a few hours. Cc: @jzmaddock and @mborland and @NAThompson |
To be more clear @AtariDreams to me it would seem nice to get #835 (cycling in CI now) merged (see work by @jzmaddock). Then merge that updated develop into your branch and then run all of CI. Thoughts? |
That makes sense. Perfect! |
Redundant casts, noexcept for move constructors, and usage of default and delete make the code more performant and maintainable