Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junk removal #863

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Junk removal #863

merged 1 commit into from
Nov 10, 2022

Conversation

AZero13
Copy link
Contributor

@AZero13 AZero13 commented Oct 30, 2022

Removal of junk headers, typos, or mistakenly duplicated keywords

@AZero13
Copy link
Contributor Author

AZero13 commented Oct 30, 2022

Done @jzmaddock

@AZero13
Copy link
Contributor Author

AZero13 commented Oct 31, 2022

@mborland Ready!

@jzmaddock
Copy link
Collaborator

@AtariDreams : other than my 2 comments above, I'm happy with this one (but I think those two need to be addressed).

@AZero13
Copy link
Contributor Author

AZero13 commented Nov 4, 2022

#include <boost/math/distributions/detail/inv_discrete_quantile.hpp> was removed and the project failed to build as a result, so I think we need to keep it as is

@AZero13
Copy link
Contributor Author

AZero13 commented Nov 4, 2022

Also the first complaint of yours was addressed @jzmaddock

@jzmaddock
Copy link
Collaborator

There are two issues mentioned above: the workaround removed from tools/config.hpp properly belongs in tools/workaround.hpp (and yes we really do need float.h and not cfloat when the workaround is active), and the change to tools/precision.hpp will introduce a new compiler warning as it implicitly converts int to bool.

Removal of junk headers, typos, or mistakenly duplicated keywords
@AZero13
Copy link
Contributor Author

AZero13 commented Nov 5, 2022

Done! @jzmaddock

@AZero13
Copy link
Contributor Author

AZero13 commented Nov 9, 2022

@mborland All ready!

@jzmaddock jzmaddock merged commit 57afd55 into boostorg:develop Nov 10, 2022
@jzmaddock
Copy link
Collaborator

Ooops, merged too soon: "constructible" is the correct spelling as least as far as the C++ standard is concerned. Changed that back in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants