Fix warnings in special functions #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzmaddock
reviewed
Nov 4, 2022
| @@ -239,7 +239,7 @@ | |||
| return r; | |||
| } | |||
| int s1, s2; | |||
| T r = boost::math::lgamma(T(z + n), &s1, pol) - boost::math::lgamma(z, &s2, pol); | |||
| auto r = static_cast<T>(boost::math::lgamma(T(z + n), &s1, pol) - boost::math::lgamma(z, &s2, pol)); | |||
There was a problem hiding this comment.
@mborland this diff all looks good to go to me, but just for future reference, I'm curious why this one warns as the results of the lgamma calls should be T's (even in the float case)?
There was a problem hiding this comment.
I assume z is an integer type so the call boost::math::lgamma(z, &s2, pol) is promoting to double. If that is a bad assumption I am not sure why, or if that was intentional.
There was a problem hiding this comment.
Which compiler/test case was triggering the warnings?
There was a problem hiding this comment.
Which compiler/test case was triggering the warnings?
Example is here using MSVC 2022 running git_issue_810 with C++20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.