Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of Boost.Array #568

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Remove uses of Boost.Array #568

merged 5 commits into from
Nov 3, 2023

Conversation

mborland
Copy link
Member

Closes: #567

@jzmaddock
Copy link
Collaborator

Not sure why this worked before... apparently boost::rational has no swap non-member, so we need a using std::swap in the test case.

@mborland
Copy link
Member Author

mborland commented Nov 2, 2023

@jzmaddock Any idea why the following now pops up in GNU mode?

../../../boost/math/special_functions/beta.hpp:573:35: error: call of overloaded 'log1p(boost::multiprecision::number<boost::multiprecision::backends::mpfr_float_backend<100>, (boost::multiprecision::expression_template_option)0>)' is ambiguous
             power1 = exp(a * log1p((x * b - y * a) / a + p * (x * c / a)));

@jzmaddock
Copy link
Collaborator

That's weird, and new :(

Not just gnu mode as the clang tests are failing too, I'll see if I can reproduce....

jzmaddock added a commit to boostorg/math that referenced this pull request Nov 2, 2023
This fixes ambiguous overloads in the multiprecision case between boost::multiprecision and boost::math versions of log1p.
See boostorg/multiprecision#568 (comment)
@jzmaddock
Copy link
Collaborator

Fix here: boostorg/math#1043

@mborland
Copy link
Member Author

mborland commented Nov 2, 2023

Fix here: boostorg/math#1043

Thank you. Once that is merged I will re-run the CI here.

@mborland mborland merged commit 246dbe5 into develop Nov 3, 2023
66 checks passed
@mborland mborland deleted the boost_array branch November 3, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boost failed to runtest with error C2027, C2676 and error C2059
2 participants