-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost::future_errc not usable #323
Comments
…g#323. Moves the concrete definition of `future_errc` to the auxiliary "detail" namespace, making ADL look in there. Employs 'using' statements for the reuse of extant `make_error_code` and `make_error_condition` functions, along with ensuring backward compatibility.
…g#323. Moves the concrete definition of `future_errc` to the auxiliary "detail" namespace, making ADL look in there. Employs 'using' statements for the reuse of extant `make_error_code` and `make_error_condition` functions, along with ensuring backward compatibility.
Hi, I investigated this a little bit and discovered that it can be simplified to such code:
My understanding is that ADL cannot find I figured out we could trick ADL a little bit by introducing a helper namespace and I'm trying to deliver a PR #390 based on that idea. |
|
Hi @pdimov, thanks your interest and sorry for the long wait. Yes, you're right that So... I'm just pointing that out but I'm open for making an exception here and do it like you proposed so the code is more simplified. Please let me know what you think. |
Fix usage of make_error_code before its declaration. Resolves boostorg#323.
Compiler: gcc 9.3.0, clang++ 9.0.1 / c++17 mode
Boost: 1.73
This fails with
The text was updated successfully, but these errors were encountered: