Support a single #pragma without body #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code assumed there was at least one space following #pragma, but that is not required.
|
If merged this will resolve #188 |
rlenhardt
reviewed
Jan 12, 2024
| @@ -2456,7 +2455,6 @@ pp_iterator_functor<ContextT>::on_pragma( | |||
| #endif | |||
| } | |||
| } | |||
| expanded.push_back(result_type(T_NEWLINE, "\n", act_token.get_position())); | |||
There was a problem hiding this comment.
Removing the final new line will cause emitted pragmas to miss the final new line and be misintepreted by following compile steps. For example
#pragma foo
#define X hello
X
will currently get preprocessed to
#pragma foo#define X hello
X
but should be actually
#pragma foo
hello
Shall i add an issue with more details?
There was a problem hiding this comment.
Yikes, yes please!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach differs from the initial plan - which just returned when an empty pragma was detected - because we still need to fire pragma hooks.