Update checkout CI action to v4 #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this may allow it to run directly in ubuntu 20.04. At any rate it will match the accumulators library, which passes for these two compilers.
Atomic doesn't seem to need this, maybe wave doesn't either
This may be necessary on Ubuntu 18.04 (our chosen container)
The code for the Ubuntu 18.04 container appears to work in a separately downloaded Docker image so I'm trying to do comparisons
My theory is that since we run in a container it doesn't matter, plus Github deprecates these periodically in an unpleasant manner (randomly shuts them off for brief periods). Furthermore this makes the config file closer to Boost.Atomic, which works.
jefftrull
force-pushed
the
bugfix/update-ci-checkout
branch
from
89c9c01 to
5477b3e
Compare
Previous code (for 16.04 and 18.04) does things that are not needed in 20.04
Many comments online suggest v4 is to blame for glibc version errors
jefftrull
force-pushed
the
bugfix/update-ci-checkout
branch
2 times, most recently
from
29dbb3d to
a0a79cb
Compare
jefftrull
force-pushed
the
bugfix/update-ci-checkout
branch
from
a0a79cb to
ba3df0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some errors with glibc versions being out of date vs. the run container which this may help.