Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line directive emitted in middle of multiline string #226

Conversation

njnobles
Copy link
Contributor

Attempts to address #225

PR reverts the changes to cpp_iterator.hpp that were introduced in #140

Nick Nobles added 2 commits September 25, 2024 13:46
Signed-off-by: Nick Nobles <nicholas_nobles@intuit.com>
Signed-off-by: Nick Nobles <nicholas_nobles@intuit.com>
@jefftrull
Copy link
Collaborator

Sorry I misunderstood the test situation here, you already thoughtfully provided one as you did for #223!

I'll try to come up with my own fix that doesn't completely revert #140 since I like the refactoring part of it. #170 is the redundant commit (w.r.t this bug).

@jefftrull
Copy link
Collaborator

Thanks for all the work you've done on this. It's far more detail than we usually get for bugs, and I appreciate it.
We're going to close this in favor of improving the lexer error checking, rejecting these kinds of constructs entirely.

@jefftrull jefftrull closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants