make environment variable BOOT_LOCAL_REPO usable on windows #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace special characters when building path components when the environment variable BOOT_LOCAL_REPO is set. Previously we ended up trying to use illegal filenames like C:\home\.boot\cache\boot\customC:\home\.m2\... on windows. Since we now also replace the path separators, we use a single directory under boot/custom/ instead of a deep directory structure. This may lead to a single path component being too long. But that is a future issue. see #243 for more information.
|
superseded by #246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace special characters when building path components when the
environment variable BOOT_LOCAL_REPO is set.
Previously we ended up trying to use illegal filenames like
C:\home.boot\cache\boot\customC:\home.m2... on windows.
Since we now also replace the path separators, we use a single directory
under boot/custom/ instead of a deep directory structure.
This may lead to a single path component being too long. But that is a
future issue.
see #243 for more information.