Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cheshire to 5.6... #679

Closed
wants to merge 1 commit into from
Closed

Conversation

lsnape
Copy link
Contributor

@lsnape lsnape commented Jan 3, 2018

This forces the jackson.databind transitive dependency in the boot/worker project to be bumped up to 2.6, in order to fix compatability issues with s3-wagon-private version 1.3. See s3-wagon-private/s3-wagon-private#45 for more information.

The problem is the s3-wagon-private library functions are invoked within the builtin push task, in the context of the boot worker pod. The worker pod includes an old version cheshire, which includes a version of jackson that conflicts with s3-wagon-private.

Version 1.3 of s3-wagon-private is particularly attractive because it uses the DefaultAWSCredentialsProviderChain.

To mitigate any unwanted changes I've found the earliest version (5.6) of cheshire that bumps jackson to a compatible version.

This forces the jackson.databind transitive dependency to be bumped
up to 2.6, in order to fix compatability issues with s3-wagon-private.
@lsnape
Copy link
Contributor Author

lsnape commented Jan 4, 2018

Hold fire on this. I'm still having issues locally despite bumping the jackson versions...

@martinklepsch
Copy link
Member

@lsnape thanks for looking into this and sorry you ran into this issue.

Let me know if you find a solution that seems to consistently fix the issue.
I guess keeping these dependencies up to date isn't a bad thing either way.

@lsnape
Copy link
Contributor Author

lsnape commented Jan 5, 2018

No problem @martinklepsch!

Bumping the cheshire version does in fact fix the problem; it was my approach to testing that was wrong!

To test this, I called set-worker-pod! with a version of 'boot/worker', containing the upgraded cheshire, before the push task was invoked. However, the function add-wagon! loads 's3-wagon-private' on the default worker pod way earlier than that, so it was still blowing up.

A simple make install forces the newer 'boot/worker' to be used consistently throughout the tooling, and shows 's3-wagon-private' working as expected. 🎉

lsnape added a commit to lsnape/s3-wagon-private that referenced this pull request Jan 5, 2018
To match versions pulled in by aws-java-sdk-s3.

Fixes s3-wagon-private#45. See also boot-clj/boot#679.
@martinklepsch
Copy link
Member

Fixed 999a608 & e715563

@martinklepsch
Copy link
Member

martinklepsch commented Jan 9, 2018

Thanks for contributing & congrats to becoming a contributor @lsnape 🙂

@lsnape
Copy link
Contributor Author

lsnape commented Jan 9, 2018

Brilliant thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants