Parse complex optargs with sequential types #682

arichiardi · 2018-01-09T21:41:48Z

This patch enables to parse options using complex optargs like SYM:VER=PATH
with types that are not nested but straight up sequential, like [sym str str].

arichiardi · 2018-01-09T21:50:29Z

boot/core/build.boot

-  (boot.util/info "Testing against version %s\n" (App/config "BOOT_VERSION"))
-  (comp (runtests)
+(deftask integration-test []
+  (set-env! :source-paths #{"integration-test"})


I am always tripping on this one. It is not working, will fix it.

arichiardi · 2018-01-10T03:51:53Z

Don't understand why the tests are failing in this very weird way:

FAIL in boot.cli-test/cli-tests (cli_test.clj:43)                               
parse-cli
[fix #578] split arguments with two different separators using vector optarg.
expected: {:parent [prj "1.3" "parent"]}
  actual: {:parent [ prj "1.3" "parent"]}
    diff: - {:parent [prj]}
          + {:parent [ prj]}

What is the space there I can't understand, but I will 👍

This patch enables to parse options using complex optargs like SYM:VER=PATH with types that are not nested but straight up sequential, like [sym str str].

martinklepsch

Looks good to me. I haven't needed something but given that tests are added and this doesn't break existing behavior we're probably fine to add it.

Two minor suggestions / questions.

Also there is some documentation which seems to suggest that this existed before? Or maybe I'm confusing things? At the end here: https://github.com/boot-clj/boot/wiki/Task-Options-DSL#complex-options

Please make sure this is up to date & add an example if it feels appropriate.

martinklepsch · 2018-01-12T08:23:11Z

CHANGES.md

@@ -34,6 +34,7 @@ and `technomancy` for the above explanation.
 - Bump [pomegranate](https://github.com/cemerick/pomegranate) and [dynapath](https://github.com/tobias/dynapath) to `1.0.0`. [#612][612]
 - Digest `java.io.File` instead `String` path of jar at sift-action `:add-jar` method [#678][678]
 - Add warning about improper use of repl :eval option [#666][666]
+- Parse complex optargs with sequential types [682][682]


Maybe add an example here what was previously possible and whats possible now.

Ok I will add one

martinklepsch · 2018-01-12T08:25:10Z

boot/core/src/boot/cli.clj

+  But the typical usage is:
+
+    ((parse-fn SYM:VER=PATH) \"prj:1.3=parent\") => [prj 1.3 parent]"
+  [optarg]


Would this also work?

((parse-fn SYM:VER=PATH=) \"prj:1.3=parent=more-stuff\")

Probably no because the parsing needs A-Z interleaved by symbols at the moment

Err, I made a typo I meant this:

((parse-fn SYM:VER=PATH=MORE) \"prj:1.3=parent=more-stuff\")

Question is if this pattern can repeat indefinitely or if there is some limit to it?

Yes it works, I tried it by having a test, one second I am going to push it

This is actually just a small test plus some test refactoring that will introduce the concept of integration vs unit test (now done with boot-alt-test).

martinklepsch · 2018-01-13T11:16:13Z

CHANGES.md

@@ -34,6 +34,7 @@ and `technomancy` for the above explanation.
 - Bump [pomegranate](https://github.com/cemerick/pomegranate) and [dynapath](https://github.com/tobias/dynapath) to `1.0.0`. [#612][612]
 - Digest `java.io.File` instead `String` path of jar at sift-action `:add-jar` method [#678][678]
 - Add warning about improper use of repl :eval option [#666][666]
+- Parse complex optargs with sequential types, see [wiki section][sequential-optargs] [#682][682]


That's perfect 👌

martinklepsch · 2018-01-13T11:20:59Z

Merged 197f991 69e2957 9b21dd9

martinklepsch · 2018-01-13T11:22:09Z

I need to revisit my workflow for merging PRs bit annoyed that this is picked up as closed instead of merged now. 😏

arichiardi force-pushed the fix-multi-separator-cli branch 2 times, most recently from 5fffc8a to 41824a3 Compare January 9, 2018 21:43

arichiardi commented Jan 9, 2018

View reviewed changes

arichiardi force-pushed the fix-multi-separator-cli branch 2 times, most recently from dd0b064 to 1600b5f Compare January 10, 2018 03:50

arichiardi force-pushed the fix-multi-separator-cli branch 2 times, most recently from 32b5af4 to 1bf6038 Compare January 10, 2018 20:29

arichiardi changed the title ~~WIP - [Fix #544] Correctly parse arguments with multiple separators~~ Fix parsing of complex optargs with sequential types Jan 10, 2018

arichiardi requested review from micha and martinklepsch January 10, 2018 20:33

arichiardi changed the title ~~Fix parsing of complex optargs with sequential types~~ Parse complex optargs with sequential types Jan 10, 2018

arichiardi force-pushed the fix-multi-separator-cli branch from 1bf6038 to 63fc8b1 Compare January 10, 2018 20:35

[Fix #578] Parse complex optargs with sequential types

fd4e6e0

This patch enables to parse options using complex optargs like SYM:VER=PATH with types that are not nested but straight up sequential, like [sym str str].

arichiardi force-pushed the fix-multi-separator-cli branch from 63fc8b1 to 750f1e4 Compare January 10, 2018 20:36

arichiardi mentioned this pull request Jan 10, 2018

Handle pom <parent> tag #579

Closed

martinklepsch approved these changes Jan 12, 2018

View reviewed changes

arichiardi force-pushed the fix-multi-separator-cli branch from 750f1e4 to c84db02 Compare January 12, 2018 18:14

Introduce complex optargs tests and refactor test tasks

5eeec07

This is actually just a small test plus some test refactoring that will introduce the concept of integration vs unit test (now done with boot-alt-test).

arichiardi force-pushed the fix-multi-separator-cli branch 2 times, most recently from 868f8dd to 8b5ff32 Compare January 12, 2018 18:33

Update CHANGES.md

e98a79d

arichiardi force-pushed the fix-multi-separator-cli branch from 8b5ff32 to e98a79d Compare January 12, 2018 18:35

martinklepsch reviewed Jan 13, 2018

View reviewed changes

martinklepsch closed this Jan 13, 2018

martinklepsch deleted the fix-multi-separator-cli branch January 13, 2018 11:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse complex optargs with sequential types #682

Parse complex optargs with sequential types #682

arichiardi commented Jan 9, 2018 •

edited

Loading

arichiardi Jan 9, 2018

arichiardi commented Jan 10, 2018 •

edited

Loading

martinklepsch left a comment

martinklepsch Jan 12, 2018

arichiardi Jan 12, 2018

martinklepsch Jan 12, 2018 •

edited

Loading

arichiardi Jan 12, 2018

martinklepsch Jan 12, 2018 •

edited

Loading

arichiardi Jan 12, 2018

martinklepsch Jan 13, 2018

martinklepsch commented Jan 13, 2018

martinklepsch commented Jan 13, 2018

Parse complex optargs with sequential types #682

Parse complex optargs with sequential types #682

Conversation

arichiardi commented Jan 9, 2018 • edited Loading

arichiardi Jan 9, 2018

Choose a reason for hiding this comment

arichiardi commented Jan 10, 2018 • edited Loading

martinklepsch left a comment

Choose a reason for hiding this comment

martinklepsch Jan 12, 2018

Choose a reason for hiding this comment

arichiardi Jan 12, 2018

Choose a reason for hiding this comment

martinklepsch Jan 12, 2018 • edited Loading

Choose a reason for hiding this comment

arichiardi Jan 12, 2018

Choose a reason for hiding this comment

martinklepsch Jan 12, 2018 • edited Loading

Choose a reason for hiding this comment

arichiardi Jan 12, 2018

Choose a reason for hiding this comment

martinklepsch Jan 13, 2018

Choose a reason for hiding this comment

martinklepsch commented Jan 13, 2018

martinklepsch commented Jan 13, 2018

arichiardi commented Jan 9, 2018 •

edited

Loading

arichiardi commented Jan 10, 2018 •

edited

Loading

martinklepsch Jan 12, 2018 •

edited

Loading

martinklepsch Jan 12, 2018 •

edited

Loading