Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace printHexBinary and add JDK 11 to travis #702

Merged
merged 3 commits into from
Jun 30, 2018
Merged

Replace printHexBinary and add JDK 11 to travis #702

merged 3 commits into from
Jun 30, 2018

Conversation

tirkarthi
Copy link
Contributor

  • This removes dependency on DataTypeConverter which results in compile time error on JDK 11.
  • Add JDK 11 to Travis

Closes #698

Ref implementation : https://github.com/twosigma/webtau/pull/58/files

@alandipert
Copy link
Contributor

alandipert commented Jun 29, 2018 •
edited
Loading

This is great, thank you. Could you please add a note to CHANGELOG.md describing the change?

@alandipert alandipert added this to the 2.8.2 milestone Jun 29, 2018
@tirkarthi
Copy link
Contributor Author

I have added a changelog entry but it might have some merge conflicts when other PRs are merged and I will resolve it.

Thanks

@alandipert alandipert merged commit 3412153 into boot-clj:master Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changelog missing Enhancement
Projects
None yet
Milestone
2.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tirkarthi @alandipert