Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:append and :prepend not applied to collection selects. #428

Closed
lcreid opened this issue Feb 8, 2018 · 4 comments
Closed

:append and :prepend not applied to collection selects. #428

lcreid opened this issue Feb 8, 2018 · 4 comments

Comments

@lcreid
Copy link
Contributor

lcreid commented Feb 8, 2018

If the user provides :append and :prepend options to select, the text/HTML will be appended or prepended to the control. If the user provides those options to collection_select or grouped_collection_select, they have no effect. I don't see why this should be inconsistent.

I'm not sure whether this is a bug or a feature request.

At ae08c5b (Feb 15, 2014), specifically ae08c5b#diff-d858d9de5eda99f11a7840b6c015c89eR8 and ae08c5b#diff-d858d9de5eda99f11a7840b6c015c89eR40, the handling of select and collection_select were moved out of the "generic" definition of the bootstrap_form helpers. In doing so, it looks like they both lost :append and :prepend.

It looks like it was fixed for select with PR #327 (Apr 24, 2017), but not for the other select methods.

@lcreid
Copy link
Contributor Author

lcreid commented Feb 15, 2018

#327 (comment) says there was no reason why only select got :prepend and :append.

@donv
Copy link
Collaborator

donv commented Feb 15, 2018

Right, I added what I needed at the time.

@lcreid
Copy link
Contributor Author

lcreid commented Feb 15, 2018

@donv no worries. I agree that it's best to do what you need and no more. I just wanted to make sure your comment was visible in this issue, too. Thanks very much for your support!

@lcreid
Copy link
Contributor Author

lcreid commented Feb 21, 2018

The Bootstrap documentation for input groups implies that input groups can wrap input tags, custom selects, and custom file input, but not the browser default versions of selects and file inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants