-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hide_label
and skip_label
for check boxes and radio buttons
#414
Conversation
I think this looks great. The important part is that we have good test coverage for these new cases, which you have done. Thanks! One question I have is whether |
I convinced myself that |
@mattbrictson good call on questioning me about |
BTW, I'm pretty sure that It looks like this was discussed in #161. Someone suggested it wasn't needed because, at least for I guess that means this might be considered a breaking change, since someone upgrading might get quite different markup compared to v2.7. At the very least, probably something for the "Upgrading" document. It looks like this is the source of a number of issues: #162, #161, and #149. |
bootstrap-ruby#414) * Update hide_label and skip_lable for Bootstrap 4.
This PR updates markup for check boxes and radio buttons to Bootstrap 4. It applies to the
radio
andcheck_box
helpers only, not thecollection_radio_buttons
andcollection_check_boxes
. The collection versions should probably be discussed under #412.Further clean-up of this code is possible, but an attempt was made to minimize changes (not always successful, mind you).
This is part of the response to #395.