-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b-form-select incorrectly renders with .form-control class #1896
Comments
There's an issue with Bootstrap twbs/bootstrap#23058 |
BTW, as you can see here https://codepen.io/cih/pen/OEzEzw - the difference is only in case of using |
I have a custom I see that Bootstrap are changing the |
It was placed there to compensate for original issues with custom selects (missing sizes, missing 100% width, not matching heights of other form-controls, etc) Of which most have been fixed. It will be removed in the upcoming release if the next update of BS V4.1 includes the fixes. BTW. Nothing is preventing you from using a basic |
#1896) Removes temporary classes needed to address issues with form selects from bootstrap V4.0.x
According to https://getbootstrap.com/docs/4.1/components/forms/#select-menu the markup for creating a custom select is as follows:
<select class="custom-select">...</select>
When using
<b-form-select>
, the rendered markup is:<select class="form-control custom-select">
The inclusion of the
.form-control
class is incorrect. In fact, it triggers the following Bootstrap CSS which causes the height of the select element to be smaller than it ought to be.The rendered markup of this component should be the same as the Bootstrap prescribed markup.
The text was updated successfully, but these errors were encountered: