Skip to content

Commit

Permalink
[#370] only show Tilt notification if not config-store
Browse files Browse the repository at this point in the history
The Configuration Store requires special logic to be deployed properly
via Tilt.  When deciding on where the MVP should be and weighing the
options against our planned move _away_ from Tilt, we decided it was
best to just exclude the configuration store from local deployments for
now and provide projects with instructions upon request.  However, in
doing that we accidentally routed the config store to the standard Tilt
manual action notification, which doesn't work at all.

This change correctly supresses the Tilt manual action if it is for the
config store.  Note that the only real way to ensure this check was to
use the `appName`, which technically could be changed by a downstream
project which would result in the manual action reappearing.  This is an
edge case, and again the plan is to move away from Tilt completely
anyway and that work is scheduled to start immediately after the Java
upgrade.
  • Loading branch information
ewilkins-csi committed Sep 26, 2024
1 parent a44625d commit cf5d4b6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion DRAFT_RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Bug Fixes
- TBD

- Remove incorrect manual action for adding Configuration Store to Tiltfile

# Known Issues
Refer to the release notes for [1.9](https://github.com/boozallen/aissemble/releases/tag/aissemble-root-1.9.1)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ protected VelocityContext configureWithoutGeneration(GenerationContext generatio

final ManualActionNotificationService manualActionNotificationService = getNotificationService();
final String deployArtifactId = generationContext.getArtifactId();
addTiltNotification(generationContext, appName, deployArtifactId);
if (!"configuration-store".equals(appName)) {
addTiltNotification(generationContext, appName, deployArtifactId);
}

final String appDependencies = generationContext.getPropertyVariables().get(APP_DEPENDENCIES);
if (!StringUtils.isEmpty(appDependencies)) {
Expand Down

0 comments on commit cf5d4b6

Please sign in to comment.