Feature: Add imagePullSecrets support to Policy Decision Point chart

[lemuelwatts]

Description

The v2 charts for Policy Decision Point do not currently allow for the user to add an imagePullSecret so that images can be pulled from private image registries. We would like to add this functionality to the chart so that it can be used more easily in downstream projects that require the use of a private image registry.

DOD

• Add Policy Decision Point chart reference to imagePullSecret
• Verify Policy Decision Point chart can be rendered that includes the imagePullSecret field and value
• Add unit test around adding support for imagePullSecret.
• Update README to support imagePullSecrets to Policy Decision Point Chart.
• Verify aissemble build is successful.
• Verify Downstream project that uses PDP with imagePullSecret is successful.

Test Strategy/Script

• On Github, Go to Settings,

• On left tab Go to Developer setting.

• Click on personal access token (classic) and generate classic token.
  Scope should be something like this:
  

• Copy the gpg key ( personal access token)

• Create secret with this command
  kubectl create secret docker-registry regcred --docker-server=ghcr.io --docker-username={your github name} --docker-password={your Personal access token}

• Check to see if you have any PDP docker images by running command
  docker image
  something like this:
  {projectname}-policy-decision-point-docker tilt-16367d62958476b5 16367d629584 23 hours ago 417MB
  NOTE: if you don't have any pdp-docker image, run downstream project with pdp and deploy, then this docker image will be generated.

• Change Docker tag to your private registry.
  docker tag {projectname}-policy-decision-point-docker:{tilt-tag} ghcr.io/{github username}/issue-302-policy-decision-point-docker:1.0.0-SNAPSHOT

• push docker tag to your private registry
  docker push ghcr.io/{github username}/issue-302-policy-decision-point-docker:1.0.0-SNAPSHOT

• check to confirm you have package uploaded
  https://github.com/{your github username}?tab=packages

• pull in latest dev branch of aissemble

• make sure build is successful
  Build downstream project using following command:

 mvn archetype:generate -U -DarchetypeGroupId=com.boozallen.aissemble \
  -DarchetypeArtifactId=foundation-archetype \
  -DarchetypeVersion=1.10.0-SNAPSHOT\
  -DgroupId=com.boozallen.aissemble.test \
  -DartifactId=issue-302\
  -DprojectGitUrl=git.example.com/issue-302 \
  -DprojectName=“issue-302”

• cd into downstream project.
• Add a spark pipeline with a training step to an aissemble project by saving attached json into
  SparkPipeline.json
  {downstream-project}/{downstream-project}-pipeline-models/src/main/resources/pipelines
• Run ./mvn clean install and follow manual actions.
• under {downstream-project}-deploy/src/main/resources/apps/policy-decision-point/values.yaml, update imagePullSecret set to regcred
• also update dockerRepo to your private registry (i.e. ghcr.io/{github username}

Example: disregard -4 appended in the image name.

• run mvn clean install again
• Run tilt up
• Verify Policy decision point can be stood up and log says it is pulled from private registry.

References/Additional Context

Pull an image from a private registry

[jaebchoi]

DoD completed with @meliz19

[jaebchoi]

OTS completed with @jacksondelametter

[cwoods-cpointe]

Final test completed