BUG: Spark Infrastructure chart uses a hard-coded aiSSEMBLE version. #373
Assignees
Milestone
Comments
ewilkins-csi
changed the title
|
DoD/OTS with @carter-cundiff |
ewilkins-csi
added a commit
that referenced
this issue
Nov 4, 2024
ewilkins-csi
added a commit
that referenced
this issue
Nov 4, 2024
ewilkins-csi
added a commit
that referenced
this issue
Nov 5, 2024
[#373] use .Chart.AppVersion for image tags in custom charts
ewilkins-csi
added a commit
that referenced
this issue
Nov 5, 2024
Using the `.Chart.AppVersion` for image tags exposed a bug that was introduced when we moved to opensource. Previously we were overwriting path dependencies in helm charts during the release process via the `release` profile. After open-sourcing our release profile name changed from `release` to `ossrh-release`, but we didn't update it in the `extensions-helm` POM. However, it was incorrect to only rewrite dependencies during release anyway, as the chart dependencies should be rewritten _any_ time we're deploying (including snapshots). So instead we moved the functionality to the `ci` profile (which is also active during release.) Also found an issue with release-prepare introduced by #451 preventing the version update process due to unresolved property.
|
Testing passed: New version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The spark infrastructure chart was updated to use the
aissemble-sparkimage, but the tag is hard-coded. We should apply the same technique we're using in other charts to set the image tag from the Maven project directly so that the two values can't fall out of sync as easily.Steps to Reproduce
aissembleversiontag to _extensions/extensions-helm/extensions-helm-spark-infrastrucutre/pom.xml with some version number different than the current version of aiSSEMBLE. E.g.:deployment.image.tagin the values.yaml files at the following locations:Expected Result
The tag is set to the same version as the POM.
Actual Result:
The tag is hard-coded to 1.10.0-SNAPSHOT.
Test Steps
helm templatecommand on the built charts and ensurespec.template.spec.containers[0].imageuses the 1.10.0-SNAPSHOT tag<version>1.11.0</version>:helm templatecommand on the built charts and ensure the container images are set to the 1.11.0 tagThe text was updated successfully, but these errors were encountered: