Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Overwrite the ivy user directory in the spark-application chart #400

Closed
2 tasks
csun-cpointe opened this issue Oct 8, 2024 · 2 comments · Fixed by #402
Closed
2 tasks

TASK: Overwrite the ivy user directory in the spark-application chart #400

csun-cpointe opened this issue Oct 8, 2024 · 2 comments · Fixed by #402
Assignees
Labels
slacktask Small ticket done in down time task Support ticket - typically not code related
Milestone

Comments

@csun-cpointe
Copy link
Contributor

csun-cpointe commented Oct 8, 2024

Description

For java 17 upgrade, we have upgraded the aissemble-spark base image, which has a different home directory than the /opt/spark/ directory so to make sure Ivy cache can find the right directory (Ivy cache is default to the environment's home directory. e.g.: ~/.ivy2), we will need to override the ivy user directory by specifying the spark.jars.ivy directory in the chart.

Currently, to fix the build issue, we have moved the spark.jars.ivy from the spark application chart to the dev values file to avoid the local test issue. However, since our local test is not using the docker container but only copy over the spark configuration from the yaml file to configure the spark session in the local environment, we should not copy spark.jars.ivy directory for the spark tester setup but leave it as default so that it can still use the default home directory and when we deploying the spark application to different environment, we don't need to set spark.jars.ivy path in the values file.

DOD

Acceptance criteria required to complete the work

  • Move the spark.jars.ivy configuration to the aissemble-spark-application chart
  • In python or java test code, avoid spark.jars.ivy configuration being setup in the spark

Test Strategy/Script

How will this item be verified?

  • Pull the latest aissemble repo

  • OTS Only:

    • Since the aissemble-spark-application-chart is not being pushed up to GitHub packages yet, we will make some local modification
      • In thefoundation/foundation-mda/src/main/resources/templates/data-delivery-common/pipeline.chart.pom.configuration.vm, modify the line 32 to point to your local directory <<path to your baseline repo>>/extensions/extensions-helm/aissemble-spark-application-chart
      • In the foundation/foundation-mda/src/main/resources/templates/data-delivery-common/pipeline.chart.pom.configuration.vm, modify the line 24 to be {path = "/path to your baseline repo/extensions/extensions-data-delivery/aissemble-extensions-data-delivery-spark-py", develop = true}
      • Run mvn clean install -pl :foundation-mda -Dmaven.build.cache.skipCache
  • Run mvn -B clean install -Parchetype-test -pl :foundation-archetype and verify the build is success.

References/Additional Context

As needed

@csun-cpointe csun-cpointe added the task Support ticket - typically not code related label Oct 8, 2024
@csun-cpointe csun-cpointe self-assigned this Oct 8, 2024
@csun-cpointe csun-cpointe added this to the 1.10.0 milestone Oct 8, 2024
@csun-cpointe csun-cpointe changed the title TASK: Move spark ivy jar path to aissemeble-spark-application chart TASK: Overwrite the ivy user directory in the spark-application chart Oct 8, 2024
@ewilkins-csi
Copy link
Contributor

DoD/OTS looks good ✅

@carter-cundiff
Copy link
Contributor

Testing passed:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slacktask Small ticket done in down time task Support ticket - typically not code related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants