#118 Read in and validate policies for universal config properties #151

carter-cundiff · 2024-06-14T17:01:52Z

Updated config store to make use of PropertyKey object instead of group name and property name strings
Updated java and python implementations of Policy to take a list of targets rather than a single target while maintaining backwards compatability

carter-cundiff · 2024-06-14T17:02:34Z

...ore-vault/src/test/java/com/boozallen/aissemble/configuration/dao/VaultPropertyDaoSteps.java

        }
    }

-    public Set<Property> getProperties() {


I: Removed unused function

carter-cundiff · 2024-06-14T17:04:40Z

foundation/foundation-configuration-store/pom.xml

-                        <BASE_URI>/tmp/configurations/base</BASE_URI>
-                        <ENVIRONMENT_URI>/tmp/configurations/example-env</ENVIRONMENT_URI>
+                        <BASE_PROPERTY_URI>${project.basedir}/src/test/resources/configurations/base</BASE_PROPERTY_URI>
+                        <ENVIRONMENT_PROPERTY_URI>${project.basedir}/src/test/resources/configurations/example-env</ENVIRONMENT_PROPERTY_URI>


I: Moved unit tests to use existing policies within /src/test/resources/ rather than writing them to a /tmp directory outside of the repo

...figuration-store/src/main/java/com/boozallen/aissemble/configuration/store/ConfigLoader.java

...nfiguration-store/src/main/java/com/boozallen/aissemble/configuration/store/PropertyKey.java

foundation/aissemble-foundation-core-python/src/policy_manager/abstract_policy_manager.py

foundation/aissemble-foundation-core-python/src/policy_manager/policy/json/policy_input.py

foundation/aissemble-foundation-core-python/tests/features/steps/policy_test_util.py

...ain/java/com/boozallen/aissemble/configuration/policy/PropertyRegenerationPolicyManager.java

foundation/aissemble-foundation-core-python/src/policy_manager/policy/json/policy_input.py

...uration-store/src/main/java/com/boozallen/aissemble/configuration/service/ConfigService.java

...ain/java/com/boozallen/aissemble/configuration/policy/PropertyRegenerationPolicyManager.java

...configuration-store/src/main/java/com/boozallen/aissemble/configuration/ConfigStoreInit.java

...onfiguration-store/src/test/java/com/boozallen/aissemble/util/ConfigStoreInitTestHelper.java

ewilkins-csi · 2024-06-17T18:17:56Z

foundation/aissemble-foundation-core-python/src/policy_manager/policy/policy.py

+        )
+        return self.configuredTargets[0] if len(self.configuredTargets) > 0 else None
+
+    def set_deprecated_targetConfigurations(self, new_value: ConfiguredTarget):


Q/A: Do we need to support the setter? I'd have thought this was a read-only property that's determined by the definition JSON file.

In theory we probably don't since these would only be set by the abstract policy manager which does it through the new property. However the java implementation has a now deprecated setter for it, so can't hurt to maintain parity here.

...configuration-store/src/main/java/com/boozallen/aissemble/configuration/ConfigStoreInit.java

carter-cundiff commented Jun 14, 2024

View reviewed changes