#166 update redpanda/testcontainers/artemis to latest versions #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilkins-csi
commented
Jun 25, 2024
| @@ -131,7 +131,7 @@ | |||
| <dependency> | |||
| <groupId>org.testcontainers</groupId> | |||
| <artifactId>vault</artifactId> | |||
| <version>1.19.7</version> | |||
| <version>${version.testcontainers}</version> | |||
There was a problem hiding this comment.
I: All of the testcontainer artifacts like vault/mysql/etc. are released at the same time and kept on the same version. So we can just use one version property for all of them.
Cho-William
reviewed
Jun 25, 2024
| @@ -33,7 +33,7 @@ urllib3 = "^1.26.18" | |||
| black = ">=22.1.0" | |||
| behave = ">=1.2.6" | |||
| nose = ">=1.3.7" | |||
| testcontainers = ">=3.7.1" | |||
| testcontainers = ">=4.5.1" | |||
There was a problem hiding this comment.
(This is not related to this PR/Issue) but it would be nice if at some point in the future we could inject this version as a variable across the test module, since I feel like it's easy to miss updating our test module
Cho-William
approved these changes
Jun 25, 2024
JeffreyRoss
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.