#122 & #169 Feature rename Foundation Core Python & Policy Decision Point Python #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BLE landscape - Renamed the Foundation Core Python package. - Renamed the Foundation Metadata Core (Python) package. - Renamed the Foundation Encryption Policy (Python) package. - Renamed the Extensions Encryption Vault Python package. - Renamed the Extensions Data Delivery Spark (Python) package. - Renamed all the child directories, classes, and methods. - Corrected all the imports inside of the velocity templates to ensure a successful build of the Foundation Core Python. - Baton migration scripts for automated migrations from legacy package names to the new aiSSEMBLE landscape.
…as not able to find a python function which was renamed to aissemble.
habibimoiz
force-pushed
the
feature-rename-foundation-core-python
branch
from
f05f2fb to
fdf4196
Compare
aaron-gary
reviewed
Jun 27, 2024
| } | ||
|
|
||
| /** | ||
| * Performs the migration if the shouldExecuteOnFile() returns true. |
There was a problem hiding this comment.
minor: shouldExecuteOnFile() is external to this method. Can the description instead just say that it renames a file? Meaning, technically this method can be called by any other private method regardless of what shouldExecuteOnFile() returns. I can see that this method was intended to work in conjunction with shouldExecuteOnFile(), but it isn't part of this method.
There was a problem hiding this comment.
Updated the description to better describe functionality.
aaron-gary
reviewed
Jun 27, 2024
| } | ||
|
|
||
| /** | ||
| * Performs the migration if the shouldExecuteOnFile() returns true. |
There was a problem hiding this comment.
same comment as above. This method can be called regardless of what shouldExecuteOnFile() returns
There was a problem hiding this comment.
Updated the description to better describe functionality.
aaron-gary
approved these changes
Jun 27, 2024
- Refactor all the child directories, classes, and methods. - Corrected all the imports inside the velocity templates to ensure a successful build of PDP Python. - Baton migration scripts for automated migrations from legacy package names to the new aiSSEMBLE landscape.
habibimoiz
force-pushed
the
feature-rename-foundation-core-python
branch
from
fdf4196 to
94c3799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in the feature branch which consists of changes found in Issues: #122 & #169. Refactoring the foundation-core-python policy-decision-point python to remove all the aiops to aissemble.
#122: Rename Foundation Core Python module with latest aiSSEMBLE landscape
#122 Refactoring the Foundation Core Python module; removing aiops references. #163
#169: Refactor Policy Decision Point (PDP) Python module with latest aiSSEMBLE landscape.
PR: #122 Refactoring the Foundation Core Python module; removing aiops references.