#183: Refactor Foundation Data Access module with latest aiSSEMBLE landscape #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chang-annie
reviewed
Jul 5, 2024
| while((line = aiopsReferenceJavaConfig.readLine()) !=null && !shouldExecute) { | ||
| for (String key : AIOPS_REFERENCE_JAVA_PACKAGE_MAP.keySet()) { | ||
| if (line.contains(key)) { | ||
| return true; |
There was a problem hiding this comment.
should set shouldExecute to true here for clarity
There was a problem hiding this comment.
Good catch! Just made the change to set true to the shouldExecute variable.
habibimoiz
force-pushed
the
183-rename-foundation-data-access
branch
from
1d76812 to
7afbca4
Compare
|
Draft release notes markdown needs the migrations listed there |
Cho-William
approved these changes
Jul 5, 2024
- Refactor all the child directories, classes, and methods. - Corrected all the imports inside the velocity templates to ensure a successful build Foundation Data Access. - Baton migration scripts for automated migrations from legacy package names to the new aiSSEMBLE landscape.
habibimoiz
force-pushed
the
183-rename-foundation-data-access
branch
from
7afbca4 to
fcdee0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#183: Refactor Foundation Data Access module with latest aiSSEMBLE landscape:
/foundation/foundation-data-access