#199 fix environment variable substitution issue #201
Conversation
| </build> | ||
| </image> | ||
| </images> | ||
| </configuration> |
There was a problem hiding this comment.
I: clean up the duplicated execution configuration by moving the configuration out of plugin execution
| </build> | ||
| </image> | ||
| </images> | ||
| </configuration> |
There was a problem hiding this comment.
I: clean up the duplicated execution configuration by moving the configuration out of plugin execution
| ARG JARS_DIR | ||
| ADD ${JARS_DIR}/* ${SPARK_HOME}/jars/ | ||
| ADD ${JARS_DIR}/* $SPARK_HOME/jars/ |
There was a problem hiding this comment.
What about ${JARS_DIR}?
There was a problem hiding this comment.
The build argument can be replaced with ${}
There was a problem hiding this comment.
How is this any different then the $JARS_DIR in extensions/extensions-docker/aissemble-hive/aissemble-hive-service/src/main/resources/docker/Dockerfile?
There was a problem hiding this comment.
ah good catch.. I think that's been replaced by accident since the ARG can be replaced with the curl parenthesis. Both ways work for ARG type but I can replace it back for consistent but I think it's minor.
csun-cpointe
force-pushed
the
199-fix-dockerfile-env-var-substitutions
branch
from
458b0f3 to
638d5ab
Compare
We use curly braces for some of the ENV substitutions in our Dockerfiles, but because fabric8 does Maven property expansion, and by default looks for ${} to do that substitution, we were getting injection of host machine values instead of properly using the VM’s env. This PR is to change the environment variable substitution from ${X} to $X