#191 archetype and migration update for fabric8 usage in ci and it profiles #203
Conversation
Cho-William
force-pushed
the
191-fabric8-profiles
branch
2 times, most recently
from
3d3c3ba to
8485df8
Compare
| removeOldConfig.add(pomDeletePreviousVersion); | ||
| } | ||
|
|
||
| private boolean executeProfileMigration(File file, Plugin profilePlugin, String profileId) { |
There was a problem hiding this comment.
this function is the main addition to the migration, the rest of the changes in this file are largely refactorings to make shared helper functions available between the build config and profile migrations
| </images> | ||
| </configuration> | ||
| </execution> | ||
| </executions> |
There was a problem hiding this comment.
Discussed offline, but going to move these configs out of the execution block so that it will apply to all executions.
Cho-William
force-pushed
the
191-fabric8-profiles
branch
from
0344b2d to
af8eb15
Compare
| <image> | ||
| <name>${project.artifactId}:${project.version}</name> | ||
| </image> | ||
| </images> |
| <name>${project.artifactId}:${project.version}</name> | ||
| </image> | ||
| </images> | ||
| </configuration> |
There was a problem hiding this comment.
Q: Why set the image name when the config is set to skip?
There was a problem hiding this comment.
This was brought up at DOD and we as a team need to decide if we want to unify this configuration. Will be covered in different ticket
| import com.boozallen.aissemble.upgrade.migration.AbstractAissembleMigration; | ||
| import com.boozallen.aissemble.upgrade.util.pom.LocationAwareMavenReader; | ||
| import org.apache.maven.model.Build; | ||
| import org.apache.maven.model.*; |
There was a problem hiding this comment.
C: Should avoid using .* on imports.
| migratePackaging = true; | ||
| } | ||
|
|
||
| return migrateConfiguration || migrateProfile || migratePackaging; |
There was a problem hiding this comment.
S: Could simplify to return orphedomosBuildPlugin != null || orphedomosCiProfilePlugin != null || orphedomosItProfilePlugin != null || containsOrphedomosPackaging(file)
| } | ||
|
|
||
| /** | ||
| * Performs the migration if the shouldExecuteOnFile() returns true | ||
| * |
Cho-William
force-pushed
the
191-fabric8-profiles
branch
2 times, most recently
from
8d3b862 to
c31d02a
Compare
Cho-William
force-pushed
the
191-fabric8-profiles
branch
from
c31d02a to
d340666
Compare
No description provided.