#199 fix PDP service so docker changes can be tested #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deletes duplicative, unused `foundation-policy-decision-point` module - Repackages `extensions-pdp-service` to be more in-line with rest of the project - Undo aiops -> aissemble property file rename as the code hasn't been updated - Update JKS key alias to from aiops to aissemble - Add healthcheck URL to PDP service for easy testing
ewilkins-csi
force-pushed
the
199-release-fix-pdp
branch
from
50ab114 to
814df64
Compare
ewilkins-csi
commented
Jul 18, 2024
| @@ -12,7 +12,7 @@ RUN mkdir -p /deployments/krausening/ | |||
| COPY target/dockerbuild/*.jar /deployments/ | |||
|
|
|||
| COPY ./src/main/resources/truststore/aissemble-secure.jks /deployments/ | |||
| COPY ./src/main/resources/krausening/base/aissemble-security.properties /deployments/krausening/ | |||
| COPY ./src/main/resources/krausening/base/aiops-security.properties /deployments/krausening/ | |||
There was a problem hiding this comment.
I: This rename is the primary fix for PDP. Because the code that reads this file hasn't been updated to look for the new name yet, it was failing to find this config.
ewilkins-csi
commented
Jul 18, 2024
| @@ -15,7 +15,6 @@ | |||
| <description>Contains the modules used for security</description> | |||
|
|
|||
| <modules> | |||
| <module>foundation-policy-decision-point</module> | |||
There was a problem hiding this comment.
I: Other than docs/javadocs, the classes/files in this module were identical to extensions-policy-decision-point-service. I believe these ended up as duplicates during the move from isolated repos to the monorepo. (Two separate repos had the same classes and got pulled into different places in the monorepo.)
carter-cundiff
approved these changes
Jul 18, 2024
aaron-gary
approved these changes
Jul 18, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foundation-policy-decision-pointmoduleextensions-pdp-serviceto be more in-line with rest of the project