#217 implement krausening as a light weight config store #234
Conversation
| @@ -48,7 +48,7 @@ public boolean checkEmpty() { | |||
|
|
|||
There was a problem hiding this comment.
i: File moved from extensions-configuration-store-vault. That service was the implemented to set the application.properties propertyDaoClass value. Because we are now getting that value from an env var, we no longer need to have vault in a separate module to override the application.properties.
cwoods-cpointe
force-pushed
the
217-light-weight-configs
branch
from
fca2a02 to
664598f
Compare
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-failsafe-plugin</artifactId> |
There was a problem hiding this comment.
i: Used for the integration tests to set system properties
|
|
||
| logger.info("Successfully initialized store configuration properties and policies."); | ||
| status = Status.LOAD_COMPLETE; | ||
| configLoader.updateLoadStatus(true); |
There was a problem hiding this comment.
i: load status is used to skip loading properties and polices. Previously it was only set to skip after the properties were loaded. Updated to set to skip after both properties and policies are loaded
cwoods-cpointe
force-pushed
the
217-light-weight-configs
branch
2 times, most recently
from
272ecb9 to
01d908b
Compare
| <KRAUSENING_BASE>${project.basedir}/src/test/resources/configurations/base</KRAUSENING_BASE> | ||
| <KRAUSENING_EXTENSIONS>${project.basedir}/src/test/resources/configurations/example-env</KRAUSENING_EXTENSIONS> | ||
| <KRAUSENING_PASSWORD>3uQ2j_=wmP5A2q8b</KRAUSENING_PASSWORD> | ||
| <version.aissemble.vault>${project.version}</version.aissemble.vault> |
There was a problem hiding this comment.
Is this property variable necessary if vault out of the picture?
There was a problem hiding this comment.
Good point. Its only used in the integration test. For that test it needs to start up a vault instance so it needs to version
cwoods-cpointe
force-pushed
the
217-light-weight-configs
branch
from
01d908b to
8ebac72
Compare
| Given the config loader to configured to use "vault" | ||
| And the properties are loaded | ||
| When the configurations are written | ||
| Then the properties can be read |
There was a problem hiding this comment.
Q: Do we need one for Given the config loader to configured to use "krausening" or is this covered in the other scenarios?
There was a problem hiding this comment.
Yeah I should add that. Looking at it, Ill refactor the tests to pull the test resources from target so any changes during the updates are not saved into the code base
cwoods-cpointe
force-pushed
the
217-light-weight-configs
branch
from
8ebac72 to
15309d5
Compare
|
|
||
| try { | ||
| ConfigLoader configLoader = CDI.current().select(ConfigLoader.class,new Any.Literal()).get(); | ||
| configLoader.setPropertyDaoClass(propertyDaoClass); | ||
| if (configLoader.isFullyLoaded()) { |
There was a problem hiding this comment.
typo: polices -> policies
cwoods-cpointe
force-pushed
the
217-light-weight-configs
branch
2 times, most recently
from
315cd13 to
35e4a99
Compare
Leverage Krausening file watching. No need to pre load all the config on server init. Use env var to dictate which storage option to use #217 refactor universal config vault storage
cwoods-cpointe
force-pushed
the
217-light-weight-configs
branch
from
35e4a99 to
fc64573
Compare
Leverage Krausening file watching. No need to pre load all the config on server init. Use env var to dictate which storage option to use
#217 refactor universal config vault storage