[#353] update to next dev version #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update version in test files - Clean up release notes - Update helm chart readmes - Add missing deprecation warning for kafka v1
This reverts commit 6ce3245.
ewilkins-csi
commented
Sep 25, 2024
| @@ -12,19 +12,19 @@ on: | |||
| workflow_dispatch: | |||
| inputs: | |||
| releaseVersion: | |||
| description: "The version you want to release aiSSEMBLE on." | |||
| description: "Release Version" | |||
There was a problem hiding this comment.
I: These weren't super readable in the UI so updated to shorter names
ewilkins-csi
commented
Sep 25, 2024
| @@ -1,44 +1,21 @@ | |||
| # Major Additions | |||
There was a problem hiding this comment.
I: Draft release notes reset
ewilkins-csi
commented
Sep 25, 2024
| @@ -254,7 +263,7 @@ public static int getIndentSpaces(List<String> yamlFileContent, int startIndex) | |||
| int index = startIndex; | |||
| while (indentSpaces == 0) { | |||
| String line = yamlFileContent.get(index).stripTrailing(); | |||
| if (!StringUtils.isBlank(line)) { | |||
| if (!StringUtils.isBlank(line) && !isComment(line.trim()) && !isHelmFunction(line.trim())) { | |||
There was a problem hiding this comment.
I: Comments and helm functions may not follow the standard YAML indentation
ewilkins-csi
commented
Sep 25, 2024
| @@ -1,66 +1,8 @@ | |||
| [ | |||
| { | |||
| "group": "v1-9-0-migrations", | |||
| "group": "v1-10-0-migrations", | |||
There was a problem hiding this comment.
I: Reset migrations
| @@ -2,7 +2,6 @@ | |||
| ## CONFIG | Kafka Configs | |||
| ######################################## | |||
| kafka: | |||
| kafkaVersion: 3.8.0 | |||
There was a problem hiding this comment.
Q: no more version required?
There was a problem hiding this comment.
This parameter is not valid in the base chart at all and we have no templates. So it's a completely unused property.
csun-cpointe
approved these changes
Sep 25, 2024
carter-cundiff
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.