Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

331 dockerhub rate limit - Resolve 429 Too Many Requests Error #381

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

colinpalmer-pro
Copy link
Contributor

@colinpalmer-pro colinpalmer-pro commented Sep 30, 2024

Resolves the 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit Docker Hub Error.

The following changes ensure we are using our docker credentials throughout our build process:

  • Explicitly state docker.io repo in base images
    • This allows fabric8 to pick up the registry and create a config object. Without the registry specified, fabric8 doesn't create the config object
  • Update fabric8 to use own .docker config location
    • fabric8 cleans up after its done so when using the default .docker config location, fabric8 removes the docker credentials. So any module that performs a pull outside of fabric8 was no longer authenticated

…ages, update fabric8 to use own .docker config location
@@ -1,6 +1,6 @@
# Script for creating base FastAPI Docker image

FROM python:3.11
FROM docker.io/python:3.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i: explicitly stating the registry so fabric8 knows to authenticate to docker.io

@@ -599,7 +599,7 @@
</args>
<buildx>
<builderName>default</builderName>
<dockerStateDir>~/.docker</dockerStateDir>
<dockerStateDir>~/.docker/fabric8</dockerStateDir>
<platforms>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i: providing a separate .docker directory so fabric8 uses the default location but does not override/delete the default ~.docker/config.json

@d-ryan-ashcraft
Copy link
Collaborator

Thanks for working through this @colinpalmer-pro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Github Actions build workflow does not hit Docker Hub rate limit error
3 participants