#363 Update semantic data to use java 17 #386
Conversation
csun-cpointe
force-pushed
the
363-upgrade-semantic-data-java17
branch
2 times, most recently
from
e9c0937 to
07868a5
Compare
| @@ -139,7 +139,8 @@ public abstract class ${record.capitalizedName}SchemaBase extends SparkSchema { | |||
| } | |||
|
|
|||
| // Remove validation columns from valid data | |||
| Seq<String> columnsToDrop = JavaConversions.asScalaBuffer(validationColumns).toSeq(); | |||
| Seq<String> columnsToDrop = | |||
| JavaConverters.collectionAsScalaIterableConverter(validationColumns).asScala().toSeq(); | |||
There was a problem hiding this comment.
I: The JavaConverters class is only used in the generated files. With given error found in the generated error in the code, it doesn't seem used any where else so add a general message in the draft release note to reminder user the potential incompatibility of the java17 upgrade.
There was a problem hiding this comment.
What's the error? Are we missing a pom dependency?
There was a problem hiding this comment.
No.. I think this is only to replace a deprecate class JavaConversions.asScalaBuffer.
csun-cpointe
force-pushed
the
363-upgrade-semantic-data-java17
branch
3 times, most recently
from
9481f16 to
6921c44
Compare
| @@ -3,7 +3,7 @@ | |||
| ## TBD | |||
|
|
|||
| # Breaking Changes | |||
| Note: instructions for adapting to these changes are outlined in the upgrade instructions below. | |||
There was a problem hiding this comment.
Want to keep this line
DRAFT_RELEASE_NOTES.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| ## TBD | |||
|
|
|||
| # Breaking Changes | |||
| Note: instructions for adapting to these changes are outlined in the upgrade instructions below. | |||
| We have upgraded the baseline to Java 17 and the minimal required Maven version is 3.9.6. There could be some deprecated classes or incompatible dependencies. Please update your dependency modules accordingly. | |||
|
|
|||
| _There are no breaking changes in the 1.10 release._ | |||
There was a problem hiding this comment.
Can remove this line
DRAFT_RELEASE_NOTES.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| ## TBD | |||
|
|
|||
| # Breaking Changes | |||
| Note: instructions for adapting to these changes are outlined in the upgrade instructions below. | |||
| We have upgraded the baseline to Java 17 and the minimal required Maven version is 3.9.6. There could be some deprecated classes or incompatible dependencies. Please update your dependency modules accordingly. | |||
There was a problem hiding this comment.
Rephrase: With the upgrade to Java 17, the new minimum required Maven version is now 3.9.6. This can result in deprecated classes or incompatible dependencies, please update your modules accordingly.
| @@ -69,16 +52,6 @@ | |||
| </dependency> | |||
|
|
|||
| <!-- Logging Dependencies (from aiops-parent pom) --> | |||
There was a problem hiding this comment.
Would remove this comment as well
...ces/templates/data-delivery-data-records/data-delivery-separate-data-records-java.pom.xml.vm
Show resolved
Hide resolved
csun-cpointe
force-pushed
the
363-upgrade-semantic-data-java17
branch
from
6921c44 to
611bd36
Compare
foundation/foundation-mda/src/main/resources/templates/data-delivery-spark/encryption.java.vm
Show resolved
Hide resolved
csun-cpointe
force-pushed
the
363-upgrade-semantic-data-java17
branch
from
611bd36 to
7a6c9de
Compare
No description provided.