#403 pipeline-invocation-service java17 upgrade #416
Conversation
| @@ -1,4 +1,4 @@ | |||
| FROM registry.access.redhat.com/ubi9/openjdk-11-runtime:1.20 AS builder | |||
| FROM registry.access.redhat.com/ubi9/openjdk-17-runtime:1.20 AS builder | |||
There was a problem hiding this comment.
I: Although it's the same image, use a multistage build to save more than 20 mb in space.
| @@ -101,7 +101,7 @@ protected List<String> buildFinalValuesOverrides(PipelineInvocationRequest reque | |||
| List<String> args = new ArrayList<>(); | |||
|
|
|||
| args.add("--set"); | |||
| args.add("spec.serviceEnabled=false"); | |||
| args.add("service.enabled=false"); | |||
There was a problem hiding this comment.
I: spec.serviceEnabled has been updated to service.enabled
| driver: | ||
| javaOptions: "-DKRAUSENING_BASE=/opt/spark/krausening/base -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:4747" | ||
| executor: | ||
| javaOptions: "-DKRAUSENING_BASE=/opt/spark/krausening/base -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:4747" | ||
|
|
||
|
|
||
| service: | ||
| enabled: true |
| {{- toYaml . | nindent 6 }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
I: Including the missing change for the argocd spark-operator template.
There was a problem hiding this comment.
I: See the Known Issues for release 1.8. This may need to be backported to 1.9.
csun-cpointe
force-pushed
the
403-pipeline-invocation-java17-upgrade
branch
2 times, most recently
from
31c510e to
be7abcb
Compare
...ensions-helm-pipeline-invocation/aissemble-pipeline-invocation-app-chart/templates/rbac.yaml
Outdated
Show resolved
Hide resolved
...s-helm/extensions-helm-pipeline-invocation/aissemble-pipeline-invocation-app-chart/README.md
Outdated
Show resolved
Hide resolved
...s-helm/extensions-helm-pipeline-invocation/aissemble-pipeline-invocation-app-chart/README.md
Outdated
Show resolved
Hide resolved
...helm/extensions-helm-pipeline-invocation/aissemble-pipeline-invocation-app-chart/values.yaml
Outdated
Show resolved
Hide resolved
| @@ -83,7 +71,7 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.quarkus</groupId> | |||
| <artifactId>quarkus-rest-client-reactive-jackson</artifactId> | |||
| <artifactId>quarkus-resteasy-reactive-jackson</artifactId> | |||
There was a problem hiding this comment.
Q: Will this also affect extensions-messaging-quarkus? And should we be using that module here instead of duplicating the messaging setup?
There was a problem hiding this comment.
Talked offline. It's unclear why this module was using the classic resteasy client instead of this one, but this one works and the other does not. It seems these modules have had a lot of changes in recent versions of Quarkus.
As for using extensions-messaging-quarkus, that module only provides a CDI container config. Most (all?) Quarkus apps will not rely on this, so it's unclear why this module uses Quarkus at all. It's used in alerting-teams to setup the TeamsCdiContext, but that class is unused by the service. I think that this is just unneeded code that could be removed.
.../main/java/com/boozallen/aissemble/pipeline/invocation/service/endpoint/MessageEndpoint.java
Outdated
Show resolved
Hide resolved
.../main/java/com/boozallen/aissemble/pipeline/invocation/service/endpoint/MessageEndpoint.java
Outdated
Show resolved
Hide resolved
...helm/extensions-helm-pipeline-invocation/aissemble-pipeline-invocation-app-chart/values.yaml
Outdated
Show resolved
Hide resolved
csun-cpointe
force-pushed
the
403-pipeline-invocation-java17-upgrade
branch
from
be7abcb to
0efcfb8
Compare
csun-cpointe
force-pushed
the
403-pipeline-invocation-java17-upgrade
branch
2 times, most recently
from
37f87e1 to
4d120f6
Compare
csun-cpointe
force-pushed
the
403-pipeline-invocation-java17-upgrade
branch
from
4d120f6 to
450f91c
Compare
No description provided.