-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#451] remove bom-component #453
Conversation
Fixes a dependency version mismatch for pipelines when the `extensions-authzforce` dependency is removed by removing the bom-component dependency management, which has long been deprecated. This also updates the Spark pipeline MDA test POMs to align more with what they would be in a newly generated project.
@@ -161,9 +161,6 @@ | |||
|
|||
<!-- OpenLineage java --> | |||
<version.open.lineage.java>1.23.0</version.open.lineage.java> | |||
|
|||
<!-- Used for pinning version specifically test-mda-model--> | |||
<version.test.resteasy>3.15.6.Final</version.test.resteasy> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: No longer needed, as this was just a workaround for the version mismatch issue in the test-mda modules.
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>info.cukes</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: Just some general cleanup. We weren't using these dependencies.
<artifactId>geotools-wrapper</artifactId> | ||
<version>${version.geotools.wrapper}</version> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: Just normalizing to spaces instead of tabs
<dependency> | ||
<groupId>org.apache.commons</groupId> | ||
<artifactId>commons-math3</artifactId> | ||
<version>3.6.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A: This should be removed since #448 already added this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: As alluded to in the description, this aligns the dependencies of the basic Spark model test with those which would be output by MDA generation/foundation-mda
. There are small tweaks like using project.groupId
instead of the hard-coded com.boozallen.aissemble
, but otherwise the list is identical. This same comment applies to the other test model POM.
Fixes a dependency version mismatch for pipelines when the
extensions-authzforce
dependency is removed by removing the bom-component dependency management, which has long been deprecated. This also updates the Spark pipeline MDA test POMs to align more with what they would be in a newly generated project.