Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 5.1.0 #321

Merged
merged 6 commits into from
Oct 26, 2024
Merged

🚀 5.1.0 #321

merged 6 commits into from
Oct 26, 2024

Conversation

RobinTail
Copy link
Collaborator

@RobinTail RobinTail commented Oct 19, 2024 •
edited
Loading

@RobinTail
Performance tuning for number formatting (#320)
8482ccc 
* Draft: try with and without locale.

* Adjusting implementation and testing it.

* Updating QA snapshot.

* Handle negative values as well.

* Draft: performance tuning for number formatting.

* Build snapshot update.

* Covering calls for resolver.

* Allowing UMD globals in tsconfig for lodash case.

* REF: moving attempts iteration into memoized function.

* Ref: readability.

* Ref: better constraints.

* Ref: jsdoc.

* Updating build snapshot.
@RobinTail RobinTail added enhancement New feature or request release Chores for releasing new versions labels Oct 19, 2024
@coveralls
Copy link

coveralls commented Oct 19, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 7bd4f63 on develop
into 2e90b84 on master.

@RobinTail RobinTail added the refactoring Better implementation of the same thing label Oct 19, 2024
@RobinTail RobinTail marked this pull request as ready for review October 19, 2024 07:07
@RobinTail
Copy link
Collaborator Author

RobinTail commented Oct 19, 2024 •
edited
Loading

🚀 5.1.0rc1
✅ regression passed

@RobinTail RobinTail changed the title 🚀 Next 🚀 5.1.0 Oct 19, 2024
@RobinTail
Copy link
Collaborator Author

RobinTail commented Oct 19, 2024 •
edited
Loading

🚀 5.1.0rc2
✅ fixes issue for PhysicalButton plugin, able to operate relay in both plugins

  • checked on Raspberry Pi 4

Direct installation link:

https://github.com/borisbu/OctoRelay/releases/download/5.1.0rc2/release.zip

@RobinTail
Copy link
Collaborator Author

RobinTail commented Oct 19, 2024 •
edited
Loading

Dear @ch3p4ll3 ,

could you please try version 5.1.0rc2 on Raspberry Pi 5 and check:

  • there are no errors in log and you're still able to operate relays
  • the countdown still works for you

Dear @ccle610 ,

could you please try version 5.1.0rc2 on your Raspberry Pi and check:

  • there are no errors in log and you can operate a relay in both plugins, having output action in your PhysicalButton plugin having similar config:

image

@RobinTail RobinTail added the help wanted Extra attention is needed label Oct 19, 2024
@ch3p4ll3
Copy link
Contributor

ch3p4ll3 commented Oct 19, 2024 •
edited
Loading

Dear @ch3p4ll3 ,

could you please try version 5.1.0rc2 on Raspberry Pi 5 and check:

  • there are no errors in log and you're still able to operate relays
  • the countdown still works for you

Yep, everything still works on the Pi5, I don't see any errors in the logs. As soon as it finishes printing I will update you if the countdown still works

Edit: The countdown still works

@ccle610
Copy link

ccle610 commented Oct 19, 2024

Hi RobinTail,
I'm still happy with solution #263, using System Command Action for that purpose, using curl command to ask OctoRelay to do the job, version 5.1.0rc2 is running on Raspberry Pi 4.
But I can test it out, when back home again . . .

@RobinTail
Copy link
Collaborator Author

But I can test it out, when back home again . . .

Yes, please. No rush, take your time, @ccle610

@RobinTail
Copy link
Collaborator Author

Dear @ccle610 , did you have a chance to get home? :)

@ccle610
Copy link

ccle610 commented Oct 26, 2024

Hi Anna, sorry for the delay, i did not find the time during the week . . . but I've checked out what happens, when GPIO Toggle is used once again on my Octoprint 1.10.1 running OctoPi 1.0.0 atRaspi 4: Nothing ;-(
Only the Workaround through OctoRelais still is working fine (what is ok for me!)

Regards, haJue
button_config_25-1-2023_15-39-23.json
button_config_26-10-2024_12-48-55.json

@RobinTail
Copy link
Collaborator Author

RobinTail commented Oct 26, 2024 •
edited
Loading

on my Octoprint 1.10.1 running OctoPi 1.0.0 atRaspi 4: Nothing ;-(

hmmm... it's strange that it works in my case for some reason...
I also have Raspberry Pi 4, OctoPi 1.0.0 and OctoPrint 1.10.2

@ccle610
Copy link

ccle610 commented Oct 26, 2024

Hi Anna, have to say sorry!
My mistake . . . in background the Octo relais Plugin was automatical "updated" to Ver, 5.0.3 and I did not recognized that.
Now I have tested once again with 5.1.0RC2 and voila - Physical Button is working with Action "toggle GPIO" like in those good old days .
Great Job, HaJue

By the way, I have understood what I did wrong:
When I've started printig today, I was a litte in a hurry and so the Button "Update all" was pushed ;-(

Octoprint now comes up with an update message:
Aktualisierung verfügbar
Es gibt Aktualisierungen für die folgenden Komponenten:

OctoRelay: 5.0.3[Release Notes](https://github.com/borisbu/OctoRelay/releases/tag/5.0.3)

@RobinTail
Copy link
Collaborator Author

Physical Button is working with Action "toggle GPIO" like in those good old days .

Perfect! Thank you so much for testing, @ccle610
I'm super glad!

Octoprint now comes up with an update message:

Aktualisierung verfügbar
Es gibt Aktualisierungen für die folgenden Komponenten:

Yes, this is normal.
When I merge this PR and publish 5.1.0 (without rc) it will become latest and will no longer offer you downgrade.

@RobinTail RobinTail added the documentation Improvements or additions to documentation label Oct 26, 2024
RobinTail
RobinTail commented Oct 26, 2024
View reviewed changes
Copy link
Collaborator Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit 9ddbdf6 into master Oct 26, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed refactoring Better implementation of the same thing release Chores for releasing new versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Physical Button Plugin broken A way to use physical buttons
4 participants
@RobinTail @coveralls @ch3p4ll3 @ccle610