Round adjustment transactions to budget's decimal digits (fixes #23) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borsboom
force-pushed
the
23-round-adjustments
branch
from
73b52b8
to
04efae5
Compare
Also skip adjustment transactions less than two of the smallest currency unit (e.g. two cents).
borsboom
force-pushed
the
23-round-adjustments
branch
from
04efae5
to
f2d7304
Compare
|
The issue reoccurred, so trying the new release with this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wizonesolutions I believe this will prevent "cycles" like you experienced. When I fixed #8, I tried to be smart and have adjustment transactions fix difference accounts with non-zero-sub-cent balances by ensuring the final balance would be properly rounded. This required creating a non-zero-sub-cent transaction in order to do so. But it looks like that backfired in your case and it's clear that we simply can't trust the numbers coming out of the YNAB API if there are any non-zero-sub-cent values. Therefore, with this change we will no longer do that, and there is no longer any case where this tool will create a non-zero-sub-cent transaction.