Diagnostic Aggregator Testing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
…iagnostic_aggregator_demo
* Adds launch-based test, starting aggregator with a yaml configuration * Test is not yet working, something wrong with process orchestration Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
* One passing test, just looking for output of the bond statemachine * One failing test, looking for the actual analyzer output we want to test for Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
Closed
Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
norro
changed the title
Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
|
Four tests working, testing creation of various analyzers and analyzer groups from yaml specification. |
Karsten1987
reviewed
Aug 26, 2019
There was a problem hiding this comment.
Generally looks good to me. I'd like to have the std::cout though addressed.
also I went ahead and pushed 087d391 to address some failing linters.
* launch testing now working withou previous stdcout hack * deleted deprecated (not working) tests Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
|
@norro I've seen you've updated your branch here. Is this good to be merged in your original PR? |
Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
|
@Karsten1987 yes, this could/should be merged into the original PR, as it now has a small demo and working tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a demo and two tests, but...:
One of the tests is supposed to test the analyzer creation of the aggregator from a yaml file. This one, however, is failing since the output it is supposed to match somehow only appears after the test times out.
The second test is succeeding, but only checks for output of the bond state machine, which somehow already appears before the test times out, but is not meaningful to test.
@Karsten1987: This kind-of fixes this as is shows how the tests should look like IMHO. Do you have an idea why the logging output is stalled until launch-testing sends a
SIGINTto the process under test (aggregator_node)?The stalling does not happen, if I start the
aggregator_nodewithros2 run(see the demo), so it might be me using ros2 launch-testing not in the intended way.