Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #65 #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adebisi-fa
Copy link

.Net API implementation (with samples).

.Net API implementation (with samples).
@ollmer
Copy link
Contributor

ollmer commented May 12, 2016

Hello, thanks for contribution!
I see the example in commit, but not the library code. Have you missed it when created pull request?

@adebisi-fa
Copy link
Author

adebisi-fa commented May 13, 2016

Hello olimer,

Thanks for the wonderful effort you put into this project. You guys really rock. BotanIO is awesome!

No, I didn't miss adding the library code. I skipped including the .Net SDK source directly in the pull request, for two reasons:

  1. Convenience: Many .Net developers would prefer getting the SDK via Nuget to including it directly in their projects. One may wonder how other language developers have been using Botan. They might have been compiling (or interpreting) their language's sdk files (e.g. Botan.java and BotanException.java for Java) with their project source, directly. Wouldn't it have been better to publish such SDK files to any of the library repositories (npm or bower for Node, composer for PHP, Nuget for .Net, etc) to help with versioning and installation?
  2. Maintenance: As the BotanIO API evolve, update to the .Net implementation, can be maintained and repackaged to the library repositories, independent of this botanio/sdk repo.

The .Net SDK code is open and available on GitHub here (Botan.cs)

The .Net example in the commit includes the .Net SDK Nuget package name, BotanIO.Net. On Nuget, the SDK repository URL is available under the Project Site link.

All that said, I'll modify the pull request to include a link to the .Net SDK source, so as to make it easier to locate the .Net bits directly from this repo.

Hope this helps.

Thank you once for giving the world this wonderful framework!

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants