-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken hyperlink to examples #3730
Conversation
Hi @nateprewitt, @jonemo could you kindly take a look at this small PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay and thank you for catching this out-of-date link!
Could you please also change the branch name component of the URL to main
instead of master
. While the link continues to work with master
this will result in an unnecessary redirect.
docs/source/guide/examples.rst
Outdated
@@ -23,7 +23,7 @@ To propose a new code example for the AWS documentation team to consider produci | |||
The team is looking to produce code examples that cover broader scenarios and use cases, | |||
versus simple code snippets that cover only individual API calls. For instructions, see | |||
the "Proposing new code examples" section in the | |||
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/master/README.rst>`_. | |||
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/master/README.md>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/master/README.md>`_. | |
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/README.md>`_. |
Signed-off-by: emmanuel-ferdman <emmanuelferdman@gmail.com>
@jonemo no worries. I have changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
PR Summary:
This PR addresses a broken hyperlink present in the documentation that should direct users to the README file within the
aws-doc-sdk-examples
repository. The issue arose from a change in the README file's format (note this PR) - it was transitioned fromREADME.rst
toREADME.md
. Therefore, this PR modifies the hyperlink to correctly direct to the updatedREADME.md
file.