Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken hyperlink to examples #3730

Merged
merged 2 commits into from
Jul 3, 2023
Merged

docs: fix broken hyperlink to examples #3730

merged 2 commits into from
Jul 3, 2023

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary:
This PR addresses a broken hyperlink present in the documentation that should direct users to the README file within the aws-doc-sdk-examples repository. The issue arose from a change in the README file's format (note this PR) - it was transitioned from README.rst to README.md. Therefore, this PR modifies the hyperlink to correctly direct to the updated README.md file.

@emmanuel-ferdman
Copy link
Contributor Author

Hi @nateprewitt, @jonemo could you kindly take a look at this small PR?

Copy link
Contributor

@jonemo jonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay and thank you for catching this out-of-date link!

Could you please also change the branch name component of the URL to main instead of master. While the link continues to work with master this will result in an unnecessary redirect.

@@ -23,7 +23,7 @@ To propose a new code example for the AWS documentation team to consider produci
The team is looking to produce code examples that cover broader scenarios and use cases,
versus simple code snippets that cover only individual API calls. For instructions, see
the "Proposing new code examples" section in the
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/master/README.rst>`_.
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/master/README.md>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/master/README.md>`_.
`Readme on GitHub <https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/README.md>`_.

Signed-off-by: emmanuel-ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman
Copy link
Contributor Author

@jonemo no worries. I have changed to main branch. Thanks for the review 😄

Copy link
Contributor

@jonemo jonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@dlm6693 dlm6693 merged commit 7923d26 into boto:develop Jul 3, 2023
aws-sdk-python-automation added a commit that referenced this pull request Jul 5, 2023
* release-1.27.1:
  Bumping version to 1.27.1
  Add changelog entries from botocore
  docs: Fix broken Django Project hyperlink (#3767)
  docs: fix broken hyperlink to examples (#3730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants