Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for compressed responses #1255

Open
thehesiod opened this issue Aug 2, 2017 · 2 comments
Open

add support for compressed responses #1255

thehesiod opened this issue Aug 2, 2017 · 2 comments
Labels
feature-request This issue requests a feature. p2 This is a standard priority issue

Comments

@thehesiod
Copy link

thehesiod commented Aug 2, 2017

currently when botocore makes an AWS call it doesn't set any Accept-Encoding so it comes back as plain text. If we enable this by setting request.headers['Accept-Encoding'] = 'gzip' before requests are made, AWS will return back gzip'd responses if the responses are large enough (large enough dynamodb call for example. The issue is that the code after the request has no concept of compressed responses, and convert_to_response_dict tries to just look at the "content" property, which is empty for gzip'd responses.

The fix should be as simple as correctly processing gzip'd responses and adding the supported types to the headers.

@joguSD joguSD added the feature-request This issue requests a feature. label Aug 3, 2017
@joguSD
Copy link
Contributor

joguSD commented Aug 3, 2017

Thanks for the feature request!
Related: aws/aws-cli#1131

@AravindGopala
Copy link

AravindGopala commented May 8, 2022

Is there any update on this request?, looks like its been 5 years since the feature request is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

4 participants