Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back missing fast fail states to create/update cfn waiters #1056

Merged
merged 3 commits into from
Oct 19, 2016
Merged

Add back missing fast fail states to create/update cfn waiters #1056

merged 3 commits into from
Oct 19, 2016

Commits on Oct 19, 2016

  1. Add back ROLLBACK_COMPLETE as a terminal failure state 

    StackCreateComplete can transition to a ROLLBACK_COMPLETE
when waiting for stack creation to complete.  The only action
upon reaching this state is to delete the stack.
    @jamesls
    jamesls committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    998f04a View commit details
    Browse the repository at this point in the history

  2. Add back UPDATE_ROLLBACK_COMPLETE as fast fail case in waiter 

    For the update stack complete waiter, a failed update can result in
an UPDATE_ROLLEBACK_COMPLETE.  The unfortunate part here you
cannot use this waiter until you call UpdateStack, which is the
only cfn waiter that has this restriction.  This means a previous
UpateStack failed, calling the StackUpdateComplete waiter
before calling UpdateStack will immediately trigger the fast
fail case.
    @jamesls
    jamesls committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    14a0ef3 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @jamesls
    jamesls committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    800325e View commit details
    Browse the repository at this point in the history