Add event handler to quote the x-amz-copy-source header value as expected by S3. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Looks good.
garnaat
added a commit
that referenced
this pull request
Jan 29, 2014
Add event handler to quote the x-amz-copy-source header value as expected by S3.
|
Actually we might have to back this out. I just tried copying a unicode character with the CLI and it does not work, I get an error that the key does not exist. Are you seeing this too? |
|
Yeah, I'm seeing problems on some of the integration tests. I'll just do another PR to back this out. |
garnaat
added a commit
to garnaat/botocore
that referenced
this pull request
Jan 29, 2014
garnaat
added a commit
that referenced
this pull request
Jan 29, 2014
Backing out #221 for now. It's causing errors in the integration tests.
jamesls
added a commit
that referenced
this pull request
Jan 30, 2014
* release-0.32.0: Bumping version to 0.32.0 Update models to the lastet version Backing out #221 for now. It's causing errors in the integration tests. Add handler to override signature version based on cfg value Support one level of nested configs Add event handler to quote the x-amz-copy-source header value as expected by S3. Fixes aws/aws-cli#614. Update EC2 to latest model Adding new EU endpoint for SES.
jamesls
added a commit
to jamesls/botocore
that referenced
this pull request
Mar 4, 2014
Merged
jamesls
added a commit
that referenced
this pull request
Mar 5, 2014
* plus-s3-copy: Reintroduce handler unit tests Reintroduce #221
jamesls
added a commit
that referenced
this pull request
Mar 6, 2014
* release-0.35.0: Bumping version to 0.35.0 Update dep on jmespath to latest version Update kinesis model with latest docs Update ELB model to latest version Update Elastic Transcoder with correct set of available regions Reintroduce handler unit tests Reintroduce #221 Make pagination test more robust Add Cloudfront required params Remove Tags key from CreateSnapshot response Mark Elastic Transcoder required params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/aws-cli#614. Depends on aws/aws-cli#615