-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cgi module usage, which causes deprecation warnings on Python 3.11 #2794
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2794 +/- ##
===========================================
+ Coverage 93.57% 93.58% +0.01%
===========================================
Files 63 63
Lines 13300 13302 +2
===========================================
+ Hits 12445 12449 +4
+ Misses 855 853 -2 ☔ View full report in Codecov by Sentry. |
@nateprewitt Just saw you move CI to Python-3.11, could we get some eyes on this PR please? |
Hi @wimglenn, thanks for checking in. It's on our radar but we're currently looking at other options than Edit: I see it's slated for 3.13 in October 2025. |
Interesting, is there some problem with the stdlib email recommendation from the PEP? |
Sure, and I can see how that's a problem if your builds are running with warnings on. I think we can merge this for now and if we end up with another solution, we can revisit that later. Thanks for the PR! |
* release-1.29.13: Bumping version to 1.29.13 Update to latest partitions and endpoints Update to latest models remove cgi module usage, which causes deprecation warnings on Python 3.11 (#2794) Remove ssmsap from data directory Update quicksight sdk extras paginators
On Python 3.11, as soon as
botocore.utils
is imported there are deprecation warnings due to theimport cgi
, a module which is slated to be removed from stdlib. PEP 594 recommends replacing thecgi.parse_header
with thisemail.message
substitute.