Fixed deprecated getargspec() function for Python 3.x #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctingwai This is a Pull-Request against aws/aws-cli#800, right? |
|
@quiver Yeah. That's the same stack trace I got. |
|
Interesting, it looks like py3.4 breaks backwwards compat with getargspec. Taking a look. |
|
Ok this looks like this happens only in py3.4.1. We abstract py2/3 differences in our compat.py module, so this should probably be in the compat module. I also am going to update our .travis.yml config to run tests against py3.4 as well. Should be fixed soon. Thanks for the investigation. |
jamesls
added a commit
to jamesls/botocore
that referenced
this pull request
Jun 4, 2014
There was a fix needed for python3.4.1, as shown in boto#297 This also updates travis/tox to run tests against py3.4 Also verified the CLI tests pass.
Merged
|
Sure, it's always my pleasure to be of help. |
|
Fixed via #300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for Python 3.x when trying to run aws-cli tool "ValueError: Function has keyword-only arguments or annotations, use getfullargspec() API which can support them" error